Skip to content

feat: Add RQ id, name, alias args to add_requests and enqueue_links methods #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 22, 2025
Merged

feat: Add RQ id, name, alias args to add_requests and enqueue_links methods #1413

merged 7 commits into from
Sep 22, 2025

Conversation

Mantisus
Copy link
Collaborator

Description

  • Add support for specifying RQ dst for add_requests and enqueue_links methods

Issues

@Mantisus Mantisus self-assigned this Sep 16, 2025
vdusek
vdusek reviewed Sep 19, 2025
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also include rq_id?

My thinking was that this should apply only to the context-level helpers, not the crawler-level ones. At the crawler level, they should always use the crawler's configured request manager.

@Mantisus
Copy link
Collaborator Author

Should we also include rq_id?

Yes, I think we should, for consistency of supported parameters. Added rq_id

My thinking was that this should apply only to the context-level helpers, not the crawler-level ones.

Yes, this PR adds support for new parameters, specifically in helpers.

@Mantisus Mantisus requested a review from vdusek September 20, 2025 16:46
vdusek
vdusek requested changes Sep 21, 2025
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few details, my comments apply to their other occurrences as well.

Mantisus and others added 4 commits September 21, 2025 19:43
@Mantisus @vdusek
Update src/crawlee/_types.py
4da1693 
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
@Mantisus @vdusek
Apply suggestion from @vdusek
7e4e829 
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
@Mantisus
change order
cca6d1f
@Mantisus
fix docs
67ffa62
@Mantisus Mantisus requested a review from vdusek September 21, 2025 20:39
vdusek
vdusek approved these changes Sep 22, 2025
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdusek vdusek changed the title feat: Add rq_name and rq_alias params for add_requests and enqueue_links methods feat: Add RQ id, name, alias args to add_requests and enqueue_links methods Sep 22, 2025
@vdusek vdusek merged commit 1cae2bc into apify:master Sep 22, 2025
20 checks passed
@janbuchar janbuchar mentioned this pull request Oct 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdusek vdusek vdusek approved these changes

@Pijukatel Pijukatel Pijukatel approved these changes

Assignees

@Mantisus Mantisus

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for specifying RQ dst for add_requests and enqueue_links methods

3 participants

@Mantisus @vdusek @Pijukatel